As far as compression shorts go, they're fine as long as they aren't longer than the shorts when the wearer is just standing. Also, the official rule is that they can't have logos, but don't tear your hair out looking around for ones like that. As long as the logo is small enough to be blacked out with a sharpie, they're good to wear.