Yes, all that stuff is good. Here is a good list I recommend.
""Lighter
Leatherman
Sports Bras (For Women)
Underwear (For Women)
Compression Shorts
Paperwork (Dental X-Rays, immunization form, bank form, etc.)
Social Security Card
Drivers License
Cash (less than $100)
Credit Card
Ponytail Holders (about 40)
Metal Hair Clip Things (think they are called barrets)
Personal Hygiene Products (14 day supply)
Broken-in Black Low Quarteres
Boots
Running Shoes
Cell Phone
Glasses
Glasses Security Strap
Contacts
Framed Picture *
Boot Socks
Deoderant
Shampoo/Conditioner Combo
Perscription Meds
Address Book w/ phone numbers
Pencils/Pens
Flashlight (Mini Mag-Lite)
Blister Band-Aids
Watch*
Electric Razor*
Religious Reading Material*
Passport* (might be nice to mail after BEAST)
Sports Equipment For Corps Squad Screening*
Alarm Clock*
Travel Reciepts
R-Day Parking Pass
Prepaid Phone Card
The popular boodle would depend on your son's taste.
Zip Lock Bags (to waterproof your things because it rains a lot and to make moving stuff from the civilian bag to the issued bag faster)
I would also bring insoles for the running shoes and boots. A flashlight with red lens that attaches to things would also be helpful. Moleskin would also help since you'll most likely get blisters. I also brought 550 cord and duct tape but I never really needed it except for a spirit mission. Other than that, the list is pretty good. I used a similar one to that and brought everything on it.
Popular boodle? This ones simple: just ask your son what his favorite snacks are! I haven't seen trading going on but people do share what they have when someone runs out. Ramen Noodles or oatmeal are good (assuming he likes them) for when the work flow gets heavy so your son can have something close to a real meal and not have to leave losing homework time to the Mess Hall. (or in case he sleeps through a meal which happens sometimes on weekends). Skittles, starbursts and chocolate are all popular candy and I haven't had any problems with any of it melting. Find stuff that will last him a while because boodle can disspear pretty quickly.